Level 74
This might help even if the thread is about Laravel 5.7
1 like
Nov 27, 2021
13
Level 8
Flysystem Argument #1 ($client) must be of type Aws\S3Client
I'm using league/flysystem-aws-s3-v3 ^1.0 package to upload my images on DigitalOcean Spaces and I got the error below when I try to trigger the upload.
League\Flysystem\AwsS3v3\AwsS3Adapter::__construct(): Argument #1 ($client) must be of type Aws\S3Client, Aws\S3\S3Client given, called in /home/forge/site.com/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemManager.php on line 229
composer.json
"laravel/framework": "^8.65",
"league/flysystem-aws-s3-v3": "1.0",
.env
SPACES_ACCESS_KEY_ID=xxxxx
SPACES_SECRET_ACCESS_KEY=xxxxxxx
SPACES_DEFAULT_REGION=sgp1
SPACES_BUCKET=avatar
SPACES_ENDPOINT=sgp1.digitaloceanspaces.com
SPACES_PUBLIC=https://xxx-xxx.sgp1.digitaloceanspaces.com
filesystems.php
'spaces' => [
'driver' => 's3',
'key' => env('SPACES_ACCESS_KEY_ID'),
'secret' => env('SPACES_SECRET_ACCESS_KEY'),
'region' => env('SPACES_DEFAULT_REGION'),
'bucket' => env('SPACES_BUCKET'),
'url' => env('SPACES_PUBLIC'),
'endpoint' => env('SPACES_ENDPOINT'),
'bucket_endpoint' => true,
'visibility' => 'public',
],
Controller
use Illuminate\Support\Facades\Storage;
$user = Auth::user();
$filePath = Storage::disk('spaces')
->putFile('avatars/user-'.$user->id, $request->image, 'public');
$user->avatar = env('SPACES_PUBLIC').$filePath;
$user->save();
Level 8
@Tray2 Thank you, I see that the this is my workaround
- Add
"league/flysystem-aws-s3-v3": "^1.0",in composer.json and runcomposer update - Update
.env'sSPACES_ENDPOINTto the same value asSPACIES_PUBLIC
Level 102
Never use env outside of config files!
$user->avatar = env('SPACES_PUBLIC').$filePath;
//should be something like
$user->avatar = config('storage.spaces.url') .$filePath;
//or even better. Don't store the url at all, and use storage to resolve it you need it
$user->avatar = $filePath;
1 like
Level 8
Level 102
@benjamin1509 ouch. That's a bad mistake (not your mistake). If you ever cache your config, then all env() calls will return null
https://laravel.com/docs/8.x/configuration#configuration-caching
1 like
Level 102
Wasn't it the answer by @tray2 that solved the issue? Mine was just a tip to save yourself from trouble later on
1 like
Level 8
@Sinnbeck Thank you for all the tips you've given to me :)
Level 102
@benjamin1509 anytime. Hope it helps a bit
1 like
Level 8
use storage to resolve it
@Sinnbeck you mean here is this? https://laravel.com/docs/8.x/filesystem#retrieving-files
$contents = Storage::get('file.jpg');
in my case, I use DigitalOcean Spaces so the code will be
$contents = Storage::disk('spaces')->get($user->avatar);
Level 102
@benjamin1509 yup. Or to get an url
$url = Storage::disk('spaces')->url($user->avatar);
1 like
Level 8
@Sinnbeck Thank you very much!
Level 22
Level 8
@salla Thanks, this is only a problem with older versions of Laravel.
Please or to participate in this conversation.