Level 75
Change the orWhere.
$query->Where('status', '<' 3);
Apr 23, 2022
11
Level 1
Merging two queries, An end date less than current date with status confirmed(1) or cancelled(2) and also end date greater than equal to current date with status cancelled(2) only ? Solution please
Required reservation history o/p, An end date less than current date with status confirmed(1) or cancelled(2) and also end date greater than equal to current date with status cancelled(2) only.
$employeeId = $request->employee_id; $currentDate = Carbon::now()->toDateString();
$reservationsHistory = Booking::where(['user_id' => $employeeId])
->whereDate('end_date', '<', $currentDate)
->where(function ($query) {
$query->Where('status', 1);
$query->orWhere('status', 2);
})
->orderByDesc('created_at')
->get();
$reservationsHistory = Booking::where(['user_id' => $employeeId])
->whereDate('end_date', '>=', $currentDate)
->Where('status', 2)
->orderByDesc('created_at')
->get();
return $reservationsHistory;
Level 1
@jlrdw there is no where $query->Where('status', '<' 3);
Level 122
Isn't it just ALL records?
1 like
Level 1
@Snapey Not all records. Records having end date less than current date with status confirmed(1) or cancelled(2) and also end date greater than equal to current date with status cancelled(2) only.
Level 122
Records that are for the employee
that are before current date or after current date or equal to current date (can ignore this)
that are status 1 or status 2 (are there other status?)
ordered descending
is the same as;
$reservationsHistory = Booking::where(['user_id' => $employeeId])
->whereIn('status',[1,2])
->orderByDesc('created_at')
->get();
2 likes
Level 1
@Snapey Ok, but how to avoid upcoming reservation? Res history need to show upcoming reservation with cancelled also!
Level 122
@Nirmalraj You asked how to merge the two queries, but now you are adding additional requirements?
What status is 'cancelled' .... you see "magic numbers" are quite a code smell as they convey nothing
Level 122
$reservationsHistory = Booking::where(['user_id' => $employeeId])
->where(function($query) use($currentDate) {
$query->where('end_date','<',$currentDate)->whereIn('status',[1,2]);
})
->orWhere(function($query) use($currentDate) {
$query->where('end_date','>=',$currentDate)->where('status',2]);
}
->orderByDesc('created_at')
->get();
1 like
Level 1
@Snapey Tq, but it also getting records from different employees because of the orWhere.
Level 122
$reservationsHistory = Booking::query()
->where(function($query) use($currentDate, $employeeId) {
$query->where('end_date','<',$currentDate)
->whereIn('status',[1,2])
->where(['user_id' => $employeeId]);
})
->orWhere(function($query) use($currentDate,$employeeId) {
$query->where('end_date','>=',$currentDate)
->where('status',2])
->where(['user_id' => $employeeId]);
}
->orderByDesc('created_at')
->get();
1 like
Level 1
@Snapey Tq bro
Please or to participate in this conversation.