Level 104
Disable exception handling to get a full stack trace.
public function admins_cannot_access_page()
{
$this->refreshApplication();
$this->withoutExceptionHandling();
// rest of your test
Aug 26, 2021
25
Level 1
phpunit tests 500 status confusion with multiple guards
What my test is trying to do, is test if an admin can visit the "profile" route, and the intended behavior is they should be redirected to the "login" page so they can login as a user. Important to note is that an admin is a different guard than a user.
The test currently fails, with the message that "Response status code [500] is not a redirect status code." I'm not really sure how I should deal with this issue.
<?php
namespace Tests\Feature;
use Illuminate\Foundation\Testing\DatabaseTransactions;
use Illuminate\Foundation\Testing\WithFaker;
use Tests\TestCase;
use App\User;
use App\Admin;
use App\SuperAdmin;
class AccountPageTest extends TestCase
{
use DatabaseTransactions;
/** My other tests.... **/
/** @test **/
public function admins_cannot_access_page()
{
$this->refreshApplication();
$admin = Admin::find(1);
$response = $this->actingAs($admin, 'admin')
->get('profile')
->assertRedirect('login');
}
}
Level 28
I guess we were typing at the same time @tykus, sorry about that.
Level 28
Try without exception handling so maybe it will help you find out what the internal server error indicated by the 500
/** @test **/
public function admins_cannot_access_page()
{
$this->withoutExceptionHandling();
don't forget to import it.
Level 28
Why are you separating user types?
Level 1
Level 28
Try assigning a role or roles to a user through a pivot table. Just a suggestion :)
Level 1
How to import withoutExceptionHandling? Just trying to make sure everything's right.
Level 28
Oops, you do not need to import it.
Just add the below inside the test
$this->withoutExceptionHandling();
Level 1
It doesn't seem to make a difference unfortunately.
- Tests\Feature\AccountPageTest::admins_cannot_access_page Response status code [500] is not a redirect status code. Failed asserting that false is true.
/** @test **/
public function admins_cannot_access_page()
{
$this->withoutExceptionHandling();
$this->refreshApplication();
$admin = Admin::find(1);
$response = $this->actingAs($admin, 'admin')
->get('profile')
->assertRedirect('login');
}
Level 28
Are you using a separate database for testing?
Level 28
What version of laravel are you using?
Level 28
Why are you using RefreshApplication?
Level 1
I am.
I changed the order of the first two statements and get a different error. (It might just be something I should work out on my own)
- Tests\Feature\AccountPageTest::admins_cannot_access_page TypeError: Argument 1 passed to App\Http\Controllers\ProfilesController::getBillingAddressString() must be an instance of App\Profile, instance of App\AdminProfile given, called in C:\Users\Owner\Documents\WebDevelopment\ReachWebExperts_Github\ReachWebExpertsProject\app\Http\Controllers\ProfilesController.php on line 24
/** @test **/
public function admins_cannot_access_page()
{
$this->refreshApplication();
$this->withoutExceptionHandling();
$admin = Admin::find(1);
$response = $this->actingAs($admin, 'admin')
->get('profile')
->assertRedirect('login');
}
Level 28
There you go, Why are you refreshing the app?
There is the problem
That is the error you want
ProfilesController.php on line 24
Level 1
I can't exactly remember why I'm refreshing the app, as I wrote this code a year ago (but didn't finish fixing the code for whatever reason)
Level 28
Also DatabaseTransactions is 5.4, so wat version are you using?
Level 28
So when you call
$response = $this->actingAs($admin, 'admin')
->get('profile')
it is calling the method
App\Http\Controllers\ProfilesController::getBillingAddressString()
and that expects an instance of App\Profile but it is given and instance of App\AdminProfile and it is not happy for that.
Level 28
Now you got the info to debug. good luck :)
Level 1
@lemmon Thanks so much for the assistance. Now I have one other small problem. Now I have a test failure, instead of an error. I have the assertion:
$response = $this->actingAs($admin, 'admin') ->get('profile') ->assertRedirect('login');
And error:
- Tests\Feature\AccountPageTest::admins_cannot_access_page Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'http://127.0.0.1:8000/login' +'http://127.0.0.1:8000'
If I change ->assertRedirect('login'); to ->assertRedirect(''); then the test passes. But I know that the admin is redirected to /login page because I tested it in my own browser. I'm not sure what's behind this weird behavior.
Level 28
Die dump in the controller it might not even be getting to the part that redirects
Level 28
The redirect may be coming from somewhere else and happening after the test fails you got a post some code
Level 1
Oh it's probably my isUser middleware.
namespace App\Http\Middleware;
use Closure;
use Auth;
class IsUser
{
/**
* Handle an incoming request.
*
* @param \Illuminate\Http\Request $request
* @param \Closure $next
* @return mixed
*/
public function handle($request, Closure $next)
{
//If user is a user...
if( auth::guard('web')->check() ) {
return $next($request);
}
return redirect('');
}
}
Level 28
Maybe you need to poke around in laracasts and take a little instruction. Just a suggestion , Maybe bring your testing methods up to date as well :)
Level 1
Ok, now the test seems to be bug free :) thanks again for the help.
Level 28
It was an honor
Please or to participate in this conversation.