Some routes not working

Route::get('/shop/category/sub-category/{id}/{name}', [ProductController::class, 'subCategoryShop'])->name('subCategoryShop');

So the id and name are wildcards? Are you Route-Model binding; what is the subCategoryShop Controller looking like?

I haven't made a proper route model binding. Just showing products in a specific subcategory using the id and the name is just a slug.

public function subCategoryShop($id)
    {
        $category = Category::all();
        $cat = Category::findOrFail($id);
        $products = Product::whereHas('subCategory', function($q) use($id){
                         $q->where('sub_category_id', $id); //this refers id field from categories table
                    })
                    ->orderBy('id','desc')
                    ->paginate(18);
        return view('shop.shop', compact(['category', 'products', 'cat']));
    }

That's it. I mixed the category and subcategory functions a bit. Thanks a lot for pointing that out. I was trying to get a category with a subcategory id which worked in some cases with the same id but not all. Again, thanks alot @tykus. It working now.