Well, thought about it some more and thought.. perhaps I should just add a custom Flysytem adapter using a service provider, wrap it to catch 503 and then extend the Laravel Backup Job to throttle and or backoff. So made app/Providers/SpacesServiceProvider.php:
<?php
namespace App\Providers;
use Storage;
use App\Flysystem\CheckFor503S3Client;
use Illuminate\Support\ServiceProvider;
use Aws\S3\S3Client as S3Client;
use League\Flysystem\AwsS3v3\AwsS3Adapter;
use League\Flysystem\Filesystem;
/**
* Digital Ocean Spaces S3 Client extension
*
* @link https://github.com/thephpleague/flysystem-aws-s3-v2/issues/18
*/
class DigitalOceanSpacesServiceProvider extends ServiceProvider
{
/**
* Register services.
*
* @return void
*/
public function register()
{
// the laravel throtting and backoff functionality
$this->app->bind('cart', 'App\Flysystem\FullThrottle');
}
/**
* Bootstrap services.
*
* @return void
*/
public function boot()
{
Storage::extend('dospaces', function($app, $config) {
$client = new S3Client([
'visibility' => $config['private'],
'key' => $config['do_key'],
'secret' => $config['do_secret'],
'region' => $config['do_region'],
'base_url' => $config['do_url'],
'endpoint' => $config['do_endpoint'],
]);
$wrappedClient = new CheckFor503S3Client($client);
return new Filesystem(new AwsS3Adapter($wrappedClient, env('S3_BUCKET')));
});
}
}
and app/Console/Commands/BackupWithThrottleCommand.php:
<?php
namespace App\Console\Commands;
use Spatie\Backup\Commands\BackupCommand;
use Exception;
use Spatie\Backup\Events\BackupHasFailed;
use Spatie\Backup\Exceptions\InvalidCommand;
use Spatie\Backup\Tasks\Backup\BackupJobFactory;
class BackupWithThrottleCommand extends BackupCommand
{
public function myMethod(){
return 'myMethod';
}
}
and used PHP League Flystem example to catch errors app/Flysystem/CheckFor503S3Client.php:
<?php
declare(strict_types=1);
namespace App\Flysystem;
use Aws\CommandInterface;
use Aws\S3\Exception\S3Exception;
use Aws\S3\S3ClientInterface;
use Exception;
class CheckFor503S3Client implements S3ClientInterface
{
/**
* @var S3ClientInterface
*/
private $actualClient;
/**
* @var null|Exception
*/
private $lastException = null;
public function __construct(S3ClientInterface $actualClient)
{
$this->actualClient = $actualClient;
}
public function __call($name, array $arguments)
{
return $this->actualClient->__call($name, $arguments);
}
public function getCommand($name, array $args = [])
{
return $this->actualClient->getCommand($name, $args);
}
public function execute(CommandInterface $command)
{
try {
$this->lastException = null;
return $this->actualClient->execute($command);
} catch (Exception $exception) {
$this->lastException = $exception;
throw $exception;
}
}
public function was503()
{
if ( ! $this->lastException instanceof S3Exception) {
return false;
}
return $this->lastException->getResponse()->getStatusCode() === 503;
}
public function executeAsync(CommandInterface $command)
{
return $this->actualClient->executeAsync($command);
}
public function getCredentials()
{
return $this->actualClient->getCredentials();
}
public function getRegion()
{
return $this->actualClient->getRegion();
}
public function getEndpoint()
{
return $this->actualClient->getEndpoint();
}
public function getApi()
{
return $this->actualClient->getApi();
}
public function getConfig($option = null)
{
return $this->actualClient->getConfig($option);
}
public function getHandlerList()
{
return $this->actualClient->getHandlerList();
}
public function getIterator($name, array $args = [])
{
return $this->actualClient->getIterator($name, $args);
}
public function getPaginator($name, array $args = [])
{
return $this->actualClient->getPaginator($name, $args);
}
public function waitUntil($name, array $args = [])
{
$this->actualClient->waitUntil($name, $args);
}
public function getWaiter($name, array $args = [])
{
return $this->actualClient->getWaiter($name, $args);
}
public function createPresignedRequest(CommandInterface $command, $expires, array $options = [])
{
return $this->actualClient->createPresignedRequest($command, $expires, $options);
}
public function getObjectUrl($bucket, $key)
{
return $this->actualClient->getObjectUrl($bucket, $key);
}
public function doesBucketExist($bucket)
{
return $this->actualClient->doesBucketExist($bucket);
}
public function doesObjectExist($bucket, $key, array $options = [])
{
return $this->actualClient->doesObjectExist($bucket, $key, $options);
}
public function registerStreamWrapper(): void
{
$this->actualClient->registerStreamWrapper();
}
public function deleteMatchingObjects($bucket, $prefix = '', $regex = '', array $options = [])
{
return $this->actualClient->deleteMatchingObjects($bucket, $prefix, $regex, $options);
}
public function deleteMatchingObjectsAsync($bucket, $prefix = '', $regex = '', array $options = [])
{
return $this->actualClient->deleteMatchingObjectsAsync($bucket, $prefix, $regex, $options);
}
public function upload($bucket, $key, $body, $acl = 'private', array $options = [])
{
return $this->actualClient->upload($bucket, $key, $body, $acl, $options);
}
public function uploadAsync($bucket, $key, $body, $acl = 'private', array $options = [])
{
return $this->actualClient->uploadAsync($bucket, $key, $body, $acl, $options);
}
public function copy($fromBucket, $fromKey, $destBucket, $destKey, $acl = 'private', array $options = [])
{
return $this->actualClient->copy($fromBucket, $fromKey, $destBucket, $destKey, $acl, $options);
}
public function copyAsync($fromBucket, $fromKey, $destBucket, $destKey, $acl = 'private', array $options = [])
{
return $this->actualClient->copyAsync($fromBucket, $fromKey, $destBucket, $destKey, $acl, $options);
}
public function uploadDirectory($directory, $bucket, $keyPrefix = null, array $options = [])
{
return $this->actualClient->uploadDirectory($directory, $bucket, $keyPrefix, $options);
}
public function uploadDirectoryAsync($directory, $bucket, $keyPrefix = null, array $options = [])
{
return $this->actualClient->uploadDirectoryAsync($directory, $bucket, $keyPrefix, $options);
}
public function downloadBucket($directory, $bucket, $keyPrefix = '', array $options = [])
{
return $this->actualClient->downloadBucket($directory, $bucket, $keyPrefix, $options);
}
public function downloadBucketAsync($directory, $bucket, $keyPrefix = '', array $options = [])
{
return $this->actualClient->downloadBucketAsync($directory, $bucket, $keyPrefix, $options);
}
public function determineBucketRegion($bucketName)
{
return $this->actualClient->determineBucketRegion($bucketName);
}
public function determineBucketRegionAsync($bucketName)
{
return $this->actualClient->determineBucketRegionAsync($bucketName);
}
}
Not quite there but I think this could maybe work. What do you think @martinbean ?
