Level 75
You have wrong order of parameters in in_array
if (in_array($permission, $role->permissions)) {
//
}
By the way I recommend to you use this package
Apr 11, 2021
7
Level 1
Gate Define not working for other users except whose role_id is 1
The Below code in middleware is working fine when user has role_id 1, When I did the dd on role->permissions I get then the response is array.
But on this line
if (in_array($role->permissions, $permission)) {
I get this error for all other users whose role_id is different
in_array(): Argument #2 ($haystack) must be of type array, string given
My Roles Model has
protected $casts = [
'permissions' => 'array',
];
My User Model has
protected function role()
{
return $this->hasOne(Roles::class, 'id', 'role_id');
}
My web Middlewaregroup has
\App\Http\Middleware\RolePermissionCheck::class,
My Meddlware has
namespace App\Http\Middleware;
use Closure;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Gate;
class RolePermissionCheck
{
/**
* Handle an incoming request.
*
* @param \Illuminate\Http\Request $request
* @param \Closure $next
* @return mixed
*/
public function handle($request, Closure $next)
{
if (!empty(Auth::user()->role_id)) {
$role = Auth::user()->role;
Gate::before(
function () {
if (Auth::user()->role_id === 1) {
return true;
}
}
);
// dd($role->permissions);
foreach ($role->permissions as $permission) {
Gate::define(
$permission,
function ($role) use ($permission) {
if (in_array($role->permissions, $permission)) {
return true;
}
}
);
}
}
return $next($request);
}
}
Level 1
After Changing it I am getting This error: in_array(): Argument #2 ($haystack) must be of type array, null given
Level 75
Your code doesn't ake any sence.
You loop through $role->permissions and then you check if a permission exist in the same array.
How I said use that package what I posted above.
Level 1
I got your point I will try that package as you suggested but is there anything that can be done in the middleware so that the current code work fine.
Level 75
Why do you define a gate there, see https://laravel.com/docs/8.x/authorization#writing-gates
I suggest you watch the authorization videos in the laravel from scratch 6 video series, @Jeffreyway explains all of this stuff in detail.
And even if you use spate, it still uses laravel authorization, so either way you wind up with laravel authorization.
Level 1
Thanks Bro I will check it out
Level 1
Hi, I got the issue fixed. It is working fine now for all users.
if (!empty(Auth::user()->role_id)) {
$role = Auth::user()->role;
Gate::before(
function () {
if (Auth::user()->role_id === 1) {
return true;
}
}
);
foreach ($role->permissions as $permission) {
Gate::define(
$permission,
function ($role) use ($permission) {
if (isset($permission[$role->permissions])) {
return true;
} else {
return false;
}
}
);
}
}
return $next($request);
Please suggest me if there are changes that make it better.
Please or to participate in this conversation.