Modify API result

I have below API controller function. I am getting errors while I am trying to modify the function.

public function subcourses()
    {
        $subcourses = subcourses::with('goals','course')->get();
        $subcourses->total_marks =  $subcourses->question_mark * $subcourses->total_questions; //I am getting erros here
        return response()->json($subcourses);
    }

Sergiu17

5 years ago

Level 60

Debug it

public function subcourses() {
	dd($subcourses->total_questions, $subcourses->question_mark);
}

1 like

tykus

5 years ago

Level 104

$subcourses is a Collection.

public function subcourses()
{
    $subcourses = subcourses::with('goals','course')->get()
        ->map(function ($subcourse) {
		    $subcourse->total_marks =  $subcourse->question_mark * $subcourse->total_questions;
        });
    
    return response()->json($subcourses);
}

EDIT forgot to assign to $subcourses the result of the map operation

1 like

afoysal

5 years ago

Level 8

Thanks @tykus . I am getting result like below using your code.

[
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null,
    null
]

tykus

5 years ago

Best Answer

Level 104

Sorry, forgot to return:

public function subcourses()
{
    $subcourses = subcourses::with('goals','course')->get()
        ->map(function ($subcourse) {
		    $subcourse->total_marks =  $subcourse->question_mark * $subcourse->total_questions;
            return $subcourse;
        });
    
    return response()->json($subcourses);
}

1 like

afoysal

5 years ago

Level 8

Thanks @tykus . Your solution is working. Thanks.

martinbean

5 years ago

Level 80

@afoysal Also helps if you actually provide the error you’re getting…

1 like

Please or to participate in this conversation.