Test coverage

Hi @gocanto I don't think that 100% code coverage is that good. Its not that has a hidden return it is that throw Exception will stop everything unless you have a try catch, what you could do are several tests that will trigger all the other flows that isn't the exception, but like in this case you already done it.

@punksolid Thanks for your prompt reply.

It is not about 100% tests coverage, but having cover at all. At the moment, I have all the respective tests in place, but I still get 55% test coverage on a given file due to this.

Hence, proper builds will not approve a PR with less than 80% test coverage.

Ok I understand, you could do this but I don't think is a good idea because you will be deactivating code programatically, but only you know where does that happen.

When you are on a test it will skip that. Hope it helps

if (app()->environment('testing')) {
    throw new Exception('some error');
}

Have you tried catching the Exception in phpunit?

    protected function setUp(): void
    {
        parent::setUp();

        \Route::get('/test-exception', function () {
            if (true === false) {
                return true;
            }

            throw new \Exception('some error');
        });
    }

    /**
     * @test
     * */
    public function it_should_throw_an_exception()
    {
     // This will confirm the exception
        $this->expectException(\Exception::class);       
    
     // (Optional) Confirm exception message
        $this->expectExceptionMessage('some error');

        $this->withoutExceptionHandling()  // This is required to stop Laravel intercepting the Exception
            ->get('/test-exception');
    }

The issue is having an exception outside of a controlled structure.

If exceptions are thrown within an if or try catch statements, we would not end up with this case scenario.

Note:

It is not about testing whether a givenexception is thrown, but having a full test coverage of a given method/function that throws exceptions outside controlled structures.

Thanks

I finally found how to deal with it.

• Do not throw an exception within an unhandled structure.
• Write a happy path to coverage the code after a given exception is thrown.

Thanks, everybody!

Glad you got it working. Thanks for updating with your solution