Query filter some time returns null in laravel

add return

public function scopeFilter($query, $filter)
    {
        if ($month = $filter['month']) {
                return $query->whereMonth('created_at', Carbon::parse($month)->month);
        }

        if ($year = $filter['year']) {
                return $query->whereYear('created_at', Carbon::parse($year)->year);
         }
    }

Also you still have to return $query in case month and year are missing

public function scopeFilter($query, $filter)
    {
        if ($month = $filter['month']) {
                return $query->whereMonth('created_at', Carbon::parse($month)->month);
        }

        if ($year = $filter['year']) {
                return $query->whereYear('created_at', Carbon::parse($year)->year);
         }
         return $query;
    }

@RAS1212 - Well that was embarrassing :/ such silly mistake from my side :(

one more thing if possible related to the same topic.

if i use:

->filter(request(['month', 'year']))

instead of

 ->filter(['month' => $request->month, 'year' => $request->year])

I end up with

Undefined index: month

reference video link :

https://youtu.be/n3mKQ0o1Xr4

you know what? I would do something like this if all you care is month and year in the filter method

public function scopeFilter($query)
    {
        if ($month = request()->month) {
                return $query->whereMonth('created_at', Carbon::parse($month)->month);
        }

        if ($year = request()->year) {
                return $query->whereYear('created_at', Carbon::parse($year)->year);
         }
         return $query;
    }

so much cleaner

$posts = Post::latest()->with('author')
            ->where(['status' => 1])
            ->filter()
            ->paginate(env('RECORD_LIMIT'));

@RAS1212 - I was referencing to url : https://youtu.be/n3mKQ0o1Xr4

and in it there was no return so i never set return :(

people make mistakes @princeoo7 please mark it solved if you already got it sorted out

@RAS1212 - this works but one tiny problem now.

if i have post/may/2018 as the url i expect post from may 2018, but now i am getting all record which have month may and the year condition is skipped i suppose :/

the final solution was the below code:

public function scopeFilter($query)
    {
        if ($month = request('month')) {
                $query->whereMonth('created_at', Carbon::parse($month)->month);
        }

        if ($year = request('year')) {
                $query->whereYear('created_at', $year);
        }
    }

i was parsing the $year also with carbon and that was the issue. we don't need to return any thing as it's part of the query i suppose.

@EDOC - it's the same query just as i tried to solve it with the provided solution, i ended up with another error for the same problem. but now it's solved and i have marked the question answered.