Level 75
May 8, 2018
17
Level 4
Help to find a problem
I have 3 tables users, documents, document_user(pivot table).
I already have attach() method that works great, and trying to figure out detach() method. I created it as I see should work, but it detach() only last record in document_user, but I need to detach exactly $userId that sends from form request. Kind of confused, because my method send exact userId.
So how my method looks:
public function unshare(Request $request, $company_id, $id)
{
$document = Document::find($id);
$userId = $request['id'];
$user = User::findOrFail($userId);
$document->users()->detach($userId);
flash('Document access has been updated!');
return back();
}
My form:
<form id="unsahre" method="POST" action="/company/{{ $company->id }}/document/{{ $document->id }}/unshare">
{{ csrf_field() }}
<input type="hidden" name="id" value="{{ $user->id }}">
<a href="javascript:{}" style="color: #f0506e" onclick="document.getElementById('unsahre').submit(); return false;"><i class="fas fa-times"></i></a>
</form>
Level 4
@jlrdw The problem is, that my method looks like should work, I have clear understand about 3 tables relationship. I just need tip what's wrong with my code, bc it's shows correct logic
Level 20
https://laravel.com/docs/5.6/eloquent-relationships#updating-many-to-many-relationships
Just apply the doc
$document = Document::find($id);
$userId = $request['id'];
$document->users()->detach($userId);
Level 4
@Vilfago I tried it, but it still delate last record in document_user pivot table
Level 20
You take a look at the query?
Do you have attached many times the same document to the same user?
Level 4
@Vilfago It's document share function. User upload documents and can share or unshare it with other users. It can be done many times as user wants
Level 20
Maybe you should use syncWithoutDetaching instead of attach to avoid duplicate value. Even if I remember well, there is no LIMIT to the detach query, so it should detach everything even if there are duplicate data.
What do you mean by
delete the last record
It delete a record that is not related to the user.
Level 4
@Vifago I have tried syncWithoutDetaching but still same problem.
It's actually work super weird. Example: I have 4 files and 4 users. Every file shared with all 4 users. Screenshot: http://joxi.ru/nAyoE3BHYgDvQm
If I send unshare to the 1st doc in the row, it actually unshare second doc in the list with random user->id
If I send unshare to the any other doc in the list, it unshare only 1st doc in the list with random $user->id http://joxi.ru/D2PGbR4fpqy4Pm
Super weird.
Level 20
Do you have different id for all your form in the view? Maybe it's not the right one which is submitted.
Have a look at the data in your method
Level 4
@Vilfago Yes, check the view
<div class="uk-modal-dialog" tabIndex="-1">
<button class="uk-modal-close-default" type="button" uk-close></button>
<div class="uk-padding-large">
<h3>{{ $document->name }}</h3>
<p>The following users can view this document:</p>
<div class="uk-grid-small uk-child-width-1-4@s uk-text-center uk-background-muted" uk-grid>
@foreach($document->users as $user)
<div class=" uk-padding-small">
<form id="unsahre" method="POST" action="/company/{{ $company->id }}/document/{{ $document->id }}/unshare">
{{ csrf_field() }}
<input type="hidden" name="id" value="{{ $user->id }}">
<a href="javascript:{}" style="color: #f0506e" onclick="document.getElementById('unsahre').submit(); return false;"><i class="fas fa-times"></i></a>
</form>
<div class="uk-flex uk-flex-center uk-width-1-1">
<h5>{{ $user->first_name}} {{ $user->last_name}}</h5>
</div>
</div>
@endforeach
</div>
</div>
Level 75
Are you clearing the cache and temp views between code changes.
Level 20
All your form have the same name and id... as it come from the same loop. So I think it will always take the first form of the loop.
Try
@foreach($document->users as $user)
<div class=" uk-padding-small">
<form id="unsahre{{ $user->id }}" method="POST" action="/company/{{ $company->id }}/document/{{ $document->id }}/unshare">
{{ csrf_field() }}
<input type="hidden" name="id" value="{{ $user->id }}">
<a href="javascript:{}" style="color: #f0506e" onclick="document.getElementById('unsahre{{ $user->id }}').submit(); return false;"><i class="fas fa-times"></i></a>
</form>
<div class="uk-flex uk-flex-center uk-width-1-1">
<h5>{{ $user->first_name}} {{ $user->last_name}}</h5>
</div>
</div>
@endforeach
Level 4
@Vilfago Yeah, that looks already more like true, but it doesn't fix the problem :(
Level 122
you say it 'only detaches the last record'
You should be able to tell then which ids are being removed.
In your posted code you get the $user... what was that for?
If I were you I would
a) experiment in tinker until you understand how it works, or,
b) install debugbar and check the sql
It can be tricky to see what is going on when all your ids are 1,2,3 etc so it might be worth creating extra records so you can easily differentiate the ids
Level 4
@Vilfago Maybe I need to detach somehow detach('company_id, user_id') ?
Level 4
P.S. When its only one document record is docs table, everything works great, when more then 1 everything works bad :)
Level 122
The docs are clear
// Detach a single role from the user...
$user->roles()->detach($roleId);
but you need to make sure you are passing the right ID
Please or to participate in this conversation.