Super weird test failure with assertDatabaseHas

Hardcoding 1 assumes your database is empty at the start of the test. Maybe you forgot to use DatabaseMigrations, DatabaseTransactions; in your Test class?

Do you know for sure that the product and company created in that test example each have an id of 1?

Edit @andonovn got there first.

Also, are the quotation m arks necessary? In these types of test, I like to do a pre-assertion to check that the record(s) were created, then act, and finally an assertion to see that they were destroyed:

public function when_a_product_is_destroyed_linked_companies_will_go_away()
{
    $product = create(Product::class);
    $company = create(Company::class)

    $company->syncProducts([$product->toArray()]);

    $this->assertDatabaseHas('company_products', [
        'product_id' => $product->id,
        'company_id' => $company->id,
    ]);

    $this->actingAs($this->user)->deleteJson('/producten/'.$product->id);

    $this->assertDatabaseMissing('company_products', [
        'product_id' => $product->id,
        'company_id' => $company->id,
    ]);
}

@tykus @andonovn I use DatabaseMigrations. When I change my test to your example @tykus I receive the same failure.

I've checked with a dd() both product and company id they are both 1.

So weird -_-

OK... does this assertion work?

    $this->assertDatabaseHas('company_products', [
        'product_id' => $product->id,
        'company_id' => $company->id,
    ]);

@tykus Yes

Seems that this line is not working like you expect:

 $this->actingAs($this->user)->deleteJson('/producten/'.$product->id);

Can you assign it to a $response and make assertions based on the expected response? If you're no closer, then try dump($response->getContent()) to see if there is any exception?

@tykus when I

$response = $this->actingAs($this->user)>deleteJson('/producten/'.$product->id);

dd($response->getContent());

I receive the correct json response:

"{"status":"Verwijderd"}"

So that's correct.

When I do this:

/**
 * Destroy a product.
 *
 * @param Product $product
 * @return \Illuminate\Http\JsonResponse
 */
public function destroy(Product $product)
{
    $this->productRepo->delete($product->id);

    dd(DB::table('products')
        ->select(DB::raw('*'))
        ->get());

    return response()->json(['status' => 'Verwijderd']);
}

The result in my test is an empty collection so the product is being removed.

When I change the dd to:

 dd(DB::table('company_products')
        ->select(DB::raw('*'))
        ->get());

The test result is:

Illuminate\Support\Collection {#1026
  #items: array:1 [
    0 => {#1028
      +"product_id": "1"
      +"company_id": "1"
    }
  ]
}

That's impossible because I use foreign keys -_-

Are you depending on the database to cascade delete? Are you using SQLite for testing? Does SQLite support cascading deletes?

@tykus

Thanks for helping by the way.

Pivot migration looks like this:

Schema::create('company_products', function (Blueprint $table) {
    $table->integer('product_id')->unsigned();
    $table->integer('company_id')->unsigned();

    $table->foreign('product_id')
        ->references('id')
        ->on('products')
        ->onDelete('cascade');

    $table->foreign('company_id')
        ->references('id')
        ->on('company')
        ->onDelete('cascade');

    $table->primary(['product_id', 'company_id']);
});

My test env:

 <php>
        <env name="APP_ENV" value="testing"/>
        <env name="DB_CONNECTION" value="sqlite"/>
        <env name="DB_DATABASE" value=":memory:"/>
        <env name="CACHE_DRIVER" value="array"/>
        <env name="SESSION_DRIVER" value="array"/>
        <env name="QUEUE_DRIVER" value="sync"/>
    </php>

@tykus

By default cascade is not enabled for sqlite. I see on the web.

 'sqlite' => [
            'driver'   => 'sqlite',
            'database' => env('DB_DATABASE', database_path('database.sqlite')),
            'prefix'   => '',
            'exec'     => 'PRAGMA foreign_keys = ON;',
        ],

So I've added:

 'exec'     => 'PRAGMA foreign_keys = ON;',

see here https://laracasts.com/discuss/channels/general-discussion/l5-sqlite-foreign-key-support

But still not working. I've cleared the cache.

@tykus

Thanks for helping. I've fixed it!!

I had to put this in my AppServiceProvider boot method:

 if(config('database.default') == 'sqlite'){
            $db = app()->make('db');
            $db->connection()->getPdo()->exec("pragma foreign_keys=1");
        }

 public function boot()
    {
        if(config('database.default') == 'sqlite'){
            $db = app()->make('db');
            $db->connection()->getPdo()->exec("pragma foreign_keys=1");
        }
    }

Thanks a LOT!

Great! Had just created a new app to test same!

@tykus thanksssss haha it made me nuts :)