Level 2
I assume it is cause of the render method in the original Handler, right? How can I fix that without touching the original Handler?
Thanks!
Feb 3, 2015
17
Level 2
Additional Exception Handler in L5
Hey,
how can I add an additional exception handler at a different location?
I tried this:
<?php namespace Modules\Gewora\Exceptions;
use Exception;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Illuminate\Session\TokenMismatchException;
class Handler extends ExceptionHandler
{
/**
* A list of the exception types that should not be reported.
*
* @var array
*/
protected $dontReport = [
'Symfony\Component\HttpKernel\Exception\HttpException'
];
/**
* Report or log an exception.
*
* This is a great spot to send exceptions to Sentry, Bugsnag, etc.
*
* @param \Exception $e
* @return void
*/
public function report(Exception $e)
{
dd('Test1');
if($e instanceof TokenMismatchException) {
dd('Test2');
}
return parent::report($e);
}
/**
* Render an exception into an HTTP response.
*
* @param \Illuminate\Http\Request $request
* @param \Exception $e
* @return \Illuminate\Http\Response
*/
public function render($request, Exception $e)
{
if ($this->isHttpException($e))
{
return $this->renderHttpException($e);
}
else
{
return parent::render($request, $e);
}
}
}
But it does not catch the exception, it does not even go into the report method even though the file has been loaded correctly. What am I doing wrong?
Thanks!
Level 27
Afaik, it is not possible to have two kernel level exception handlers. You can override the current one though.
Refer to your laravelinstallation/bootstrap/app.php file and you will find the following code:
$app->singleton(
'Illuminate\Contracts\Debug\ExceptionHandler',
'App\Exceptions\Handler'
);
Usman.
Level 2
Is there a way to do that without touching any of the original files? The system should be module based and therefore should not touch the original files, just to catch an Exception.
Thank you!
Level 27
You can use middlewares for this purpose IMHO.
Level 2
Would you mind giving me an example? Not sure how that would be done with Middleware :/
Level 27
Maybe something like this:
use Closure;
class SomeMiddleware {
/**
* Handle an incoming request.
*
* @param \Illuminate\Http\Request $request
* @param \Closure $next
* @return mixed
*/
public function handle($request, Closure $next)
{
try
{
$response = $next($request);
}
catch(ModuleException $e)
{
}
return $response;
}
}
You will still be needed to specify the middleware inside the $middleware array of the App\Http\Kernel class.
Level 2
Ah I see, thanks. There is really no way to handle a simple exception without touching the main files? Can't really believe that. Maybe someone else can come up with a hint for that.
Thanks!
Level 27
You can always use inline catch blocks :)
Regards!
Level 2
Yeah, but I hoped that I can avoid that, especially because I can't (technically I can, but i would rather play with spiders. Eww, spiders) do that cause a TokenMismatchException can be thrown at so many places. Will wait a bit, maybe someone has another idea. In L4 this was not a big deal cause of App::error() :/
Thank you very much! :)
Level 56
What if you make a service provider for your module and erase this binding :
public function register()
{
$this->app->singleton(
'Illuminate\Contracts\Debug\ExceptionHandler',
'Modules\Gewora\Exceptions'
);
}
Dont know if it works but I think it is worth trying.
Of course if you want to keep the original exception handler functionalities you have to extends it (App\Exceptions\Handler) and call the parent methods in your custom exception handler.
1 like
Level 2
It does not seem to catch it :(
TokenMismatchException in VerifyCsrfToken.php line 46
Thank you!
Level 56
@Gewora What ? This is absolutely not related with CSRF verification. Check again.
Level 2
@pmall: Of course it is as I want to catch the TokenMismatchException.
Level 56
Did you registered your module's service provider in config/app.php ?
Level 2
Not directly in the app.php but it is being registered through the modules plugin.
Level 56
The modules plugin ?
Level 2
Yeah I use a modules package which handles the registration of the ServiceProvider in the corresponding module. The ServiceProvider is registered for sure.
Please or to participate in this conversation.