Laravel 5.3 and Spark

I would definitely wait till the final release of anything to worry about what's going to be what.

It would be nice to have a head's up because it could determine what I do next, depending on the answer. Thanks for your thoughts.

Agreed. I have an existing Spark project that I would like to bring up to Laravel 5.3 as soon as it is released. With the changes to the routes file and many others, I am hoping the transition from Laravel 5.2 to 5.3 and Spark will be straightforward.

Absolutely, I'm waiting on 5.3 to drop before I start work on a new project as I'd like to use a few features it has, as well as use spark to handle a lot of the scaffolding like teams / billing etc.

However if it's known that spark won't slip neatly into L5.3 / will be another months delay, then I might as well get cracking with a 5.2 base now and worry about updating at a later date.

To be clear, I think we're all OK either way, just looking for clarity.

So..

That day is here. 5.3 stable released. I'm faced with the same dilemna. After reading the upgrade guide and then learning a little about 5.3, I think these are the issues for anyone in our position:

1. Do we put 5.3 on spark?
2. Upgrade to 5.3 with our project and then put spark on it? as it is now? (1.014)
3. Fresh install 5.3 then at attempt spark install? hmm, then put project on? hmm or vice versa?
4. Be patient and wait ?

So far the first option seems the easiest solution, at least for my project.

The last option is impossible, lol. 5.3 looks great.

Anyway, has anyone had progress so far? Please share.

I'm going to attempt option #1, or at least look into it further. I'll post anything interesting or time saving here.

I've just upgraded to Laravel 5.3 from a 5.2 install running Spark. It looks like the authentication changes break Spark:

FatalErrorException in LoginController.php line 15:
Trait method hasTooManyLoginAttempts has not been applied, because there are collisions with other trait methods on Laravel\Spark\Http\Controllers\Auth\LoginController

To get Spark 1.0.14 working with Laravel 5.3 I needed to make the following changes:

spark/src/Billable.php

• Lines 45 & 50: swap the order of $key, $value

spark/src/Http/Requests/Settings/Subscription/DeterminesPlanEligibility.php

• Line 79: swap the order of $key, $team

spark/src/Http/Controllers/Auth/LoginController.php:

• Remove the ThrottlesLogins trait
• Remove the logout() method

spark/src/Repositories/PerformanceIndicatorsRepository.php

• Line 20: Add ->all() after the ->get()

Also there is a 5.3 branch on the Spark repo with the following commit (if you have access) https://github.com/laravel/spark/commit/0bab5c0b3edfd82dd4262e58fedd2cb9fd057627

Nice work, @gilbitron, you saved me some effort, thank you!

Ditto, nice work @gilbitron ,

Given the branch was created back in May and the set of changes are pretty small, looks like it will be a pretty smooth process to get this all sorted.

Now to ditch sparks API tokens and use Passport instead :)

I still feel like it may be worth waiting for an official upgrade from @TaylorOtwell. I would hate to force and upgrade, build around it, and have an official upgrade create some nasty problems because of my impatience.

Might just play it safe, although it is super tough! Great job on the new features on 5.3!!!

@gilbitron ,

That is Brave. I assumed that list of changes to be about 10 times longer thanks so much posting here

Instead I just fresh installed 5.3 and then moved files over since my project is relatively small.

I have a question though I noticed a major speed increase compared to spark. Each of my requests with spark on the local server have a delay of three to five seconds .

Does anyone else experience this delay with spark?

I'm guessing it has to do with Vue since he loads a lot of stuff on some pages specifically the settings pages.

@TaylorOtwell Updated this, PSA

Spark is only compatible with Laravel 5.2. Compatibility with Laravel 5.3 will be provided as a free upgrade in the coming weeks.

Latest update from Taylor via Twitter https://twitter.com/taylorotwell/status/770651946407428097?s=09

Will start getting Laravel Spark ready for Laravel 5.3 next week. Will be a free upgrade

Jeez golly, that makes me so darn happy.

I had to jump onto some client work (using 5.3!) and abandon my Spark project for a minute, so glad I didn't actually upgrade it manually.

As it turns out, it was a good time to take a break, thanks for the updates!

Thanks to Mr. Otwell for being an exemplar of the craft.

Just in case anyones living under a rock and hasn't seen this yet, spark now supports Laravel 5.3

https://spark.laravel.com/docs/2.0/upgrade

@gilbitron are you still having this error?

FatalErrorException in LoginController.php line 13: Trait method hasTooManyLoginAttempts has not been applied, because there are collisions with other trait methods on Laravel\Spark\Http\Controllers\Auth\LoginController

I fixed that for my application by removing the ThrottlesLogin trait from the Spark LoginController:

before:

use AuthenticatesUsers, ThrottlesLogins {
        AuthenticatesUsers::login as traitLogin;
}

afterwards:

use AuthenticatesUsers {
        AuthenticatesUsers::login as traitLogin;
}

I guess this was because the AuthenticateUsers trait it self is using the Throttles trait too.

I'd really like to see them switch from the less configuration to sass and from browserify to webpack so we can use the Laravel 5.3 configuration so we are not crossed between build tools. Or at least a quick guide explaining how to do that.

On that note, if off topic;

I'd like to see an abandonment of all of this indirection in the build process and just use the platform. I don't need Less or Sass, CSS3 is plenty. The browser support for ES2015 is also really good now, Babel is nearly pointless. I'm moving away from Laravel Elixir again, too. As cool as it is, I can write gulp watchers as needed and I don't use it for anything else.

Webpack is fairly essential to me on most new projects, but I'm about to toss all that other dross out the window. The browser platform has really matured in the last year.

Continuing to use all that stuff is sort of like making rounded corners using image sprites instead of using CSS border-radius.

/me whispers "Web Components."