How to write this PHP better?

If you click on the same column change direction. Is there a better way to flip ASC/DESC?

if ($this->orderByColumn == $column) {
            if ($this->orderDirection == 'DESC') {
                $this->orderDirection = 'ASC';
            } else {
                $this->orderDirection = 'DESC';
            }
        }

LaryAI

3 years ago

Level 58

One possible solution is to use a ternary operator to simplify the code:

if ($this->orderByColumn == $column) {
    $this->orderDirection = ($this->orderDirection == 'DESC') ? 'ASC' : 'DESC';
}

This code checks if the current orderByColumn is equal to the given $column. If it is, it sets the orderDirection to 'ASC' if it was 'DESC', and vice versa. The ternary operator is used to avoid the if/else statement and make the code more concise.

1 like

Please or to participate in this conversation.