What's Your Opinion on the Service + Repository Pattern?

@martinbean Its amazing comprehensive explanation . thanks a lot. Now i m planning to use Service class . Hope that is fine for me. i m not heard about the action class.

Also i noticed there is no php artisan command to create service class + binding

@martinbean thanks for insight on it

@martinbean Your explanation makes sense. Im wondering what you think of the use of query scopes or other methods on the model that involve eloquent queries. When your applications becomes bigger and more complex. You tend to reach for the model to add a lot these but it makes the model too big sometimes. Where would you extract this to?

@jeroensijbom I don’t have a problem with query scopes. I’d rather have a number of query scopes I can use to compose the query I want, rather than some long, convoluted repository method name that is only useful in one scenario.

Compare:

$videos = Video::query()->published()->transcoded()->paginate();

And:

$videos = Video::query()->published()->transcoded()->take(10)->get();

Versus:

$videos = $repository->getPublishedTranscodedPaginatedList();

And:

$videos = $repository->getLatestPublishedTranscodedVideos(take: 10);

Those repository methods are just going to have lots of duplication and wholly inflexible. What if I want to add an orderBy clause? That means I’m going to have to create yet another repository method to handle that scenario:

$videos = $repository->getLatestPublishedTranscodedVideosOrderByRecordingDate(take: 10);

Whereas with Eloquent, I can just go:

$videos = Video::query()->published()->transcoded()->orderBy('recording_date')->take(10)->get();

@martinbean I absolutely agree. I makes no sense to make repoitories methods with eloquent in your toolbox!

@martinbean I'm working at a company that uses this pattern and I'm so annoyed with how much work I have to do for simple things. Boilerplate code everywhere.

@martinbean what a make sense explanation. Currently, I working on my project and wondering what kind of laravel design pattern I should use. I found that there is a repository pattern and I want to implement it. But after reading your explanation, I came to conclusion that better to avoid it and use service pattern instead.

@martinbean Ai'm agree if that's only simple query like ::find(x) , in sometimes and some reasons it's waste a time if we do repository for that, but Just thinking if you have complex code like this example $videos = Video::query()->published()->transcoded()->orderBy('recording_date')->take(10)->get(); and you use that query on many controller, then, you need to add somecode or update, so instead of just change the one, you need change all of that code everywhere right? that's was the issues, yes you can simply just find all then do replce all, but how if you missing some changes?

@adityadees What’s the alternative? A method in a VideoRepository called getLatestPublishedAndTranscodedOrderedByRecordedDate?

Repositories are classes that should be used with criteria in order to retrieve objects matching that criteria, i.e.

$videos = $videos->matching(
    PublishedCriteria::class,
    TranscodedCriteria::class,
);

But then even if you did this, you’d still have to supply the criteria each and every time you wanted that subset of videos.

@adityadees depending on the complexity you can combine scopes in "child" scopes, ex: Video::query()->available()->orderBy('recording_date')->take(10)->get() where available would just chain the parent scopes you want, but I would say do this only after you see lots of duplication. Also if your models get too big you can always make your own VideoEloquentBuilder to extract your scopes, or move them to a VideoScopes trait