Undefined variable: users error

You need this

    public function index()
{
     $users = User::userr()->get();
    // $users = User::all();

    return view('users.index')->withUsers($users); // <-- add "s" to User
}

@tomi did your idea. but still generate same error

I didn't see but you must uncomment this

    public function index()
{
    // $users = User::userr()->get();
    $users = User::all();

    return view('users.index')->withUsers($users); // <-- add "s" to User
}

or you can try with

    public function index()
{
    // $users = User::userr()->get();
    $users = User::all();

    return view('users.index')->with('users', $users); // <-- add "s" to User
}

@tomi still generate same error, is this My index.blade.php file prob? I add this modification to My index. then error went away but index generate empty page no print username or email index.blade.php

 @if(isset($users))
@foreach($users as $use)
<h1>{{  $use->username } }</h1>
@endforeach
@endif

Can you try this and see if you get any users

    public function index()
{
    // $users = User::userr()->get();
    $users = User::all();
    dd($users);

    return view('users.index')->with('users', $users); // <-- add "s" to User
}

@tomi did it but not see any users.

I think that you don't have any user in database so you need put in your blade file check like you post above

 @if(isset($users))
    @foreach($users as $use)
        <h1>{{  $use->username } }</h1>
    @endforeach
@endif

@tomi No, I have five users in My users table.

Than this must work

$users = User::all();
dd($users);

https://laravel.com/docs/5.3/eloquent#retrieving-models

Do you configure your database correctly

@tomi I think I have configured database correctly. if I use this function username and email print correctly in index.blade.php

<h>{{Auth::user()->username}}</h>
<h>{{Auth::user()->email}}</h>

but when I use this

<h1>{{  $use->username } }</h1>
<h1>{{$use->email}}</h1>

it did not display????

Then i don't understand why your code for retreving users not working ...

@tomi thanks your reply

There is a space between the brackets. Should be

<h1>{{ $use->username }}</h1>

@M4rk3tt0 No it is not get any solution. genarate same error?

Maybe it's a problem in your scope

Schould be:

public function scopeUserr($query)
{
     return $query->where('id',Auth::user()->id); // Not 'username'
      
}

@M4rk3tt0 did it but not any good result?

Try,

 $users = \App\User::all();

Need to add the \App\ infront when calling user...

Perhaps..

@PeterPan OP has already imported the user model so no need for that.

I'm on my phone so apologies for formatting. In your index method, try:

$users = User::all();

return view('your view', compact('users'));

Does the query returns any data? Have you tried debugging $users variable before returning view?

@Jaytee did as you. but no any result

Just to make sure, you are using the views/users/index.blade.php file right?

@giovanniciriello when I add some new codes to My index.blade.php as following

@if(isset($users))
@foreach($users as $use)
<h1>{{$use->username}}</h1>
<p>hellow</p>
@endforeach
@endif  

view did not display any thing (empty page)

but in this way

@if(isset($users))
@foreach($users as $use)
<h1>{{$use->username}}</h1>
@endforeach
@else
<p>hellow</p>
@endif  

it is printing "hellow"

@jaytee yes sure

I wouldnt use isset here.... Maybe this is better?

@if($users)
@foreach($users as $use)
<h1>{{$use->username}}</h1>
@endforeach
@else
<p>hellow</p>
@endif  

@zachleigh when I used your way it is generated following error

Undefined variable: users (View: C:\Users\max\Desktop\c\resources\views\users\index.blade.php)

Could you post your routes please? Just to see if there are duplicates.

Also try to delete the controller and view and re do it

Can we also see your entire User model?

routes.php

Route::get('/index', function(){
    return view('users.index');
});

User Model

<?php

namespace App;
use Auth;
use Illuminate\Foundation\Auth\User as Authenticatable;

class User extends Authenticatable
{
    /**
     * The attributes that are mass assignable.
     *
     * @var array
     */
    protected $fillable = [
        'username', 'email', 'password',
    ];

    /**
     * The attributes that should be hidden for arrays.
     *
     * @var array
     */
    protected $hidden = [
        'password', 'remember_token',
    ];
    
    



public function getAvatarUrl()
{
        return "http://www.gravatar.com/avatar/" . md5(strtolower(trim($this->email))) . "?d=mm&s=40";
}

public function scopeUserr($query)
{
     return $query->where('username',Auth::user()->id);
      
}
    
}

return view('users.index');

No users.

Try this:

Route::get('/index', function(){
    $users = User::all();
    return view('users.index',  ['users' => $users]);
});

@zachleigh users means folder which index.blade.php file included in