Show total count and filtered count of relations

{{ $product->comments->where('recommended', 'Yes')->count() }}

{{ $product->comments->where('recommended', 'Yes')->count() }}

This is less efficient since it gets all of the Comment records associated with the Product and then filters before counting.

If you only need the count, then use the Query Builder comments() instead:

$recommendedComments = $product->comments()->where('recommended', 'Yes')->count();

And, try to avoid doing too much to get data in the Blade template, better to do this in the controller.

True, @tykus but since he has just called $product->comments->count() the line before, the records have already been loaded.

I felt that going into efficiency would be unnecessarily expanding the scope of the question, but now that you have opened that can of worms :)

1. You should not do these operations in Blade templates - prepare the data in the controllers and only display, loop etc. in the templates
2. You should eager load the (relevant) comments
3. You can add a relation in your Product class that can eager load just the count of recommended comments

But again - I think this is out of scope of this question.

Hi @Mithrandir

Agreed that it's out of scope of the question, but you have fuelled my curiosity. It would be really cool to see an example of your third point i.e. eager loading a count of recommended comments.

@samham do the docs for withCount() help? https://laravel.com/docs/5.7/eloquent-relationships#counting-related-models

Something like

$products = Product::withCount(['comments' => function($query) {
    $query->where('recommended', 'Yes');
})->get();

@foreach ($products as $product)
    Comment count for recommended=Yes: {{ $product->comments_count }}
@endforeach