Ordering results

Is that order dynamic? Or do you want to do that manually?

You could have a second array with your types in the wanted order and then in your blade cycle through that array and display the profiles with the given type. So if you want to reorder you only need to change that array.

@sarahs74 you can pass a callback to sortBy collection method to determine how to sort the collection values: https://laravel.com/docs/6.x/collections#method-sortby

The order is not dynamic, it will always be a set order.

@ftiersch is there no way of doing that in the controller?

$types = ['Type B', 'Type C', 'Type A'];

foreach ($types as $type) {
    foreach ($profiles->where('type', $type) as $profile) {

    }
}

I would probably do it like this. (Only that the "foreach" part would be in the blade :))

@sarahs74 try this:

$sortValues = ['Type B' => 1, 'Type C' => 2, 'Type A' => 3];

$sorted = $collection->sortBy(function ($item) use ($sortValues) {
   return $sortValues[$item->type];
});

Well as @sti3bas said you could use sortBy...

$types = ['Type B', 'Type C', 'Type A'];

$profile->sortBy(function ($profile) use ($types) {
    return array_search($profile->type, $types);
});

Maybe something like that.

I've added that to my Controller but I get:

Call to a member function sortBy() on array

am I putting it in the right place?

My original Controller was:

        $profile = Type::orderBy('type')->where('client_id', $client->id)->get();
        $profile = $profile->groupBy(function ($type) {
            return $type->type;
        })->all();
       
        
        return view('clients.show', compact('client', 'profile'));

and my View:

        @foreach($profile as $type => $types)
                            {{ $type }}
                            <ul>
                                @foreach ($types as $type)
                                    <li><a href="/clients/{{ $client->id }}/types/{{ $type->id }}">{{ $type->name }}</a></li>
                                @endforeach
                            </ul>
                        @endforeach 

@sarahs74 add sortBy before all. sortBy is a collection method and all returns an array.

You have to do something changes because when you use orderBy you have to use asc or desc and you want to use get end of the query and return with your $profile not with $type as like below,

    $profile = Type::orderBy('type')->where('client_id', $client->id)->get();
    $profile = $profile->groupBy(function ($type) {
        return $profile ->type;
    })->asc()->get();

@sti3bas The error has gone but the sorting didn't work.

@munazzil Basically nothing of that is true.

@sarahs74 can you post your latest code?

        $types = ['Individual' => 1, 'Sole Trade/Partnership' => 2, 'Company' => 3];

        $profile = Type::orderBy('type')->where('client_id', $client->id)->get();

        $profile->sortBy(function ($profile) use ($types) {
            return array_search($profile->type, $types);
        });

        $profile = $profile->groupBy(function ($type) {
            return $type->type;
        })->all();
        
        return view('clients.show', compact('client', 'profile'));

@sarahs74 try this:

$types = ['Individual', 'Sole Trade/Partnership', 'Company'];

$profile = Type::orderBy('type')
    ->where('client_id', $client->id)
    ->get()
    ->groupBy(function ($type) {
        return $type->type;
    })->sortBy(function ($profile) use ($types) {
        return array_search($profile->type, $types);
    })->all();

return view('clients.show', compact('client', 'profile'));

It has come back with this but I'm not sure what because it was OK before:

Property [type] does not exist on this collection instance.

it's this line it doesn't like type in:

return array_search($profile->type, $types);

@sarahs74 does it work this way?:

$types = ['Individual', 'Sole Trade/Partnership', 'Company'];

$profile = Type::orderBy('type')
    ->where('client_id', $client->id)
    ->get()
    ->sortBy(function ($profile) use ($types) {
        return array_search($profile->type, $types);
    })
    ->groupBy(function ($type) {
        return $type->type;
    })->all();

return view('clients.show', compact('client', 'profile'));

I think it's because it is returning as a Collection and there is no type in the Collection, it's down one level. I'm not sure how to order the Collection.

@sti3bas

No, it comes out as Sole Trader, Individual, Company .

@sarahs74 what about this?:

$types = ['Individual', 'Sole Trade/Partnership', 'Company'];

$profile = Type::orderBy('type')
    ->where('client_id', $client->id)
    ->get()
    ->groupBy(function ($type) {
        return $type->type;
    })
    ->sortBy(function ($profile, $key) use ($types) {
        return array_search($key, $types);
    })->all();

return view('clients.show', compact('client', 'profile'));

@sti3bas No, it's still the same.

@sarahs74 can you dd the $profile and post the result? So that we could see a structure.

Actually, with the SortBy I get:

array:3 [▼
  "Sole Trader/Partnership" => Collection {#530 ▶}
  "Individual" => Collection {#509 ▶}
  "Company" => Collection {#494 ▶}
]

without it I get:

array:3 [▼
  "Company" => Collection {#494 ▶}
  "Individual" => Collection {#509 ▶}
  "Sole Trader/Partnership" => Collection {#530 ▶}
]

So it's sorting alphabetically I think.

Yeah, because you order the types alphabetically in your query.

@ftiersch But I thought the SortBy in @sti3bas's solution was to sort by the array of $types at the top of that code extract.

Yes the sortby sorts the "outer" collection. That's why it isn't alphabetical anymore when you use it.

I'm not sure why it doesn't have the correct order with his code - looks correct to me.

@sarahs74 you have a typo in "Sole Trade/Partnership". I guess it should be Sole Trader/Partnership?

$types = ['Individual', 'Sole Trader/Partnership', 'Company'];

Ugh! That's solved it! Thanks for your solutions.