Image path being saved as temporary path

I store an file via a form and it works fine. But then in the update method for some reason it saves the actual file to the storage but it keeps saving a temporary path in the DB.

I've tried debugging the value of $newPathLogo and it returns the correct path until it is merged with the request then it becomes an upload file object.

    public function update(StoreOrderRequest $request, Order $order)
    {
        if (request()->user()->id === $order->user_id) {

            if ($request->hasFile('logo')) {
                if ($order->logo) {
                    Storage::disk('public')->delete($order->logo);
                }
    
                $newLogoPath = $request->file('logo')->storeAs(
                    'uploads',
                    $request->user()->id . '_' .Str::of($request->user()->name)->snake() . '.' . $request->file('logo')->extension(),
                    'public'
                );
                
                $request->merge(['logo' => $newLogoPath]);
            }

            $request->user()->orders()->update($request->except('_method', '_token'));
        } else {

            if ($request->hasFile('logo')) {
                if ($order->logo) {
                    Storage::disk('public')->delete($order->logo);
                }
    
                $newLogoPath = $request->file('logo')->storeAs(
                    'uploads',
                    $request->user()->id . '_' .Str::of($request->user()->name)->snake() . '.' . $request->file('logo')->extension(),
                    'public'
                );

                $request->merge(['logo' => $newLogoPath]);
            }

            Order::find($order->id)->update($request->except('_method', '_token'));
        }

        return redirect('/dashboard')->with('status', 'Order updated');
    }

I'm sure it's something really obvious I'm missing but just can't see it.

LaryAI

1 year ago

Best Answer

Level 58

The issue you're experiencing is likely due to the way you're merging the new file path into the request data. When you use $request->merge(), it modifies the request object, but it doesn't affect the original data that is being passed to the update() method. This can lead to the temporary file path being saved instead of the new path.

To resolve this, you should directly update the $order model with the new path before calling the update() method. Here's how you can modify your code:

public function update(StoreOrderRequest $request, Order $order)
{
    if ($request->user()->id === $order->user_id) {

        if ($request->hasFile('logo')) {
            if ($order->logo) {
                Storage::disk('public')->delete($order->logo);
            }

            $newLogoPath = $request->file('logo')->storeAs(
                'uploads',
                $request->user()->id . '_' . Str::of($request->user()->name)->snake() . '.' . $request->file('logo')->extension(),
                'public'
            );

            // Directly update the order's logo path
            $order->logo = $newLogoPath;
        }

        // Update the order with the request data
        $order->update($request->except('_method', '_token', 'logo'));
    } else {

        if ($request->hasFile('logo')) {
            if ($order->logo) {
                Storage::disk('public')->delete($order->logo);
            }

            $newLogoPath = $request->file('logo')->storeAs(
                'uploads',
                $request->user()->id . '_' . Str::of($request->user()->name)->snake() . '.' . $request->file('logo')->extension(),
                'public'
            );

            // Directly update the order's logo path
            $order->logo = $newLogoPath;
        }

        // Update the order with the request data
        $order->update($request->except('_method', '_token', 'logo'));
    }

    return redirect('/dashboard')->with('status', 'Order updated');
}

Key Changes:

Directly Assign the New Path: Instead of merging the new path into the request, directly assign it to the $order model's logo attribute.
Exclude 'logo' from update(): When calling update(), exclude the 'logo' field from the request data since it's already been set directly on the model.

This approach ensures that the correct file path is saved to the database.

Please or to participate in this conversation.