Get Users Information

$profile = User::findOrFail($id)->all();

This is returning every user in your database. Drop the all()

$profile = User::findOrFail($id);

@3684, This doesn't seem to pull out the information I need now when I var_dump

Oh i see!

$profile = User::findOrFail($id)->get('id', $id);

seems to do the trick

Apologies, I didn't read your method signature and assumed $id was just and id.

public function user(User $id)

means Laravel will inject a User instance into your function, not pass an id. It might be best to change the name of that variable to $user to avoid confusion. From your code, I assume your view is expecting a User instance. If that's the case, this should work:

public function user(User $user)
{
return view('profile.profile', compact('user'));
}

Would you suggest my working method isn't really the best route to go?

Laravel already fetches the user for you. What you're doing is just fetching it again. You might want to read up on laravel's dependency injection here: https://laravel.com/docs/5.4/controllers#dependency-injection-and-controllers

Basically, the way you have things set up, you're telling Laravel that you're expecting a parameter to be passed into your route, and that that parameter is a User instance. When a user hits that route, Laravel will attempt to find a user with a matching id and pass it into your controller. So, in the end, what's actually happening in your code is something like this:

$id = User::find($request->get('id'));

$profile = User::findOrFail($id->id);

Just to clear everything up, could you specify what you want to happen if a user id is not passed into your route?

Do you have a separate route for listing the users, such as

Route::get('/profiles/', 'UserController@index');

Sorry ill explain my intentions somewhat more.

So basically I have an online users page which will show every username online along with the count (this is functional and runs off of sessions table stored within the database).

On each username there's a hyperlink to the users profile (/profile/username) but I have it currently set to their ID instead to display their information ie: username, email address etc.

This is the code above that I posted to gather all of X users details to then display on their profile page.

When you say "gather all of X user details", it leads me to believe you might not fully understand how the model works. When you have a User instance, all of its attributes are visible to you. You're trying very hard to do something that you don't need to do, which is "fetch the profile data". You already have it in the user instance.

$profile = User::findOrFail($id)->get('id', $id);
echo $profile->name;

is the same as

echo $id->name;

because $id is an instance of User, as it is being type-hinted in the function signature.

What you're doing isn't necessarily wrong, but it is unnecessary and at the very least is making needless database requests.

Either I'm massively misunderstanding your intentions, or this would work exactly the way you want it to:

public function user(User $profile)
{
return view('profile.profile', compact('profile'));
}

and change your route's parameter name:

Route::get('/profile/{profile}', [
                'as' => 'id',
                'uses' => 'ProfileController@user'
            ]);

Alternatively, if you really don't want to change your variable name,

public function user(User $id)
{
$profile = $id;
return view('profile.profile', compact('profile'));
}

Sorry for having gone back and forth so much on this, I got very confused about the misnamed $id variable (in your controller, it's not an id, it's an object of type App\User)

I assume this is the correct url..

http://yoursite.com/profile/1

1 is the user id of the user..

Here is the clean way to do it..

web.php

Route::get('/profile/{user}','ProfileController@user');

ProfileController.php

public function user(User $user)
{
return view('profile.profile', compact('user'));
}

This is called Implicit Route Model Binding

https://laravel.com/docs/5.4/routing#route-model-binding

@eskiesirius, I figured the issue and now have it functioning as you have mentioned. My only question to extend this now would be, rather than it visiting the id of the user, how would I make it go to /profile/{username} instead using the same function within the controller?

Straight from the documentation, which @eskiesirius linked for you:

Customizing The Key Name

If you would like model binding to use a database column other than id when >retrieving a given model class, you may override the getRouteKeyName >method on the Eloquent model:

/**
* Get the route key for the model.
*
* @return string
*/
public function getRouteKeyName()
{
   return 'slug';
}  

So, in your case add this to your User model:

public function getRouteKeyName()
{
return 'username';
}

Oh yes, silly me >_< Sorry hah!