Beware # in .env files

Thank you for warning. its always good to use quotes

Thanks for the heads up.

Good to know!

Since vlucas/phpdotenv package is what handles the .env parsing. We should all read up on v3.3. https://github.com/vlucas/phpdotenv. A lot has changed since 2015 (v2.2) which was being used up until 5.7.

Basically wrap all your old string values in quotations.

I looked, not too hard, but 5.8 doesn't have anyway to hook the LoadEnvironmentVariables.php that is defined as a bootstrapper on the HTTP Kernel. It would be nice to be able to extend that internal service provider on the laravel/laravel side like any other service provider.

Since v3.3 has a bunch of new features like constraints, value type checking or seeing if a value is empty.

We could then:

• Check if the required .env variables are present
• Constrain them to certain values and/or types
• Check them before loading your app to see if they are empty or not
• etc

Something like

https://github.com/laravel/framework/blob/5.8/src/Illuminate/Foundation/Bootstrap/LoadEnvironmentVariables.php

use Illuminate\Contracts\Foundation\Application;
use Illuminate\Foundation\Bootstrap\LoadEnvironmentVariables;
use Dotenv\Exception\ValidationException;

class CustomEnvProvider extends LoadEnvironmentVariables
{

     /**
     * Override original Bootstrap
     *
     * @param  \Illuminate\Contracts\Foundation\Application  $app
     * @return void
     */
    public function bootstrap(Application $app)
    {
        if ($app->configurationIsCached()) {
            return;
        }

        $this->checkForSpecificEnvironmentFile($app);

        try {

        $env =  $this->createDotenv($app);
        $env->safeLoad();


        // Ensure debugging is a boolean
    $env->required('APP_DEBUG')->isBoolean();
    
        // Constrain the team to 3 environments
    $env->required('APP_ENV')->allowedValues([
            'local',
            'development',
        'production'
      ]);
    

        // Ensure newbies on the team have the proper set up in their .env
    $env->required([
           'APP_SERVER',
       'APP_BASE'
     ])->notEmpty();
    

        } catch (InvalidFileException $e) {
            $this->writeErrorAndDie($e);
        } catch (ValidationException $e) { // Validation exception if any of the checks fail.
           $this->writeErrorAndDie($e);
        }
    }

}

Just curious, was anything in the docs, I searched just now but did I miss something. Nothing in laravel docs I found.

Knowing me I over looked something.

No, it's not mentioned in the upgrade guide or the docs for config, although it talks about quoting multiple words for a value, like APP_NAME="My Application"

I've just PRed this to the upgrade guide so it doesn't get missed.

It's worth looking at the phpdotenv upgrade guide as there are a few other changes that might bite you if you're not aware.

This saved alot of my time