Getting mimes validation fail when not uploading optional file with AJAX

You cannot use ajax to simply POST a file to the server, file uploads are very different from data POST's.

Check this tutorial if you really want to use ajax for the file upload : http://www.ajaxf1.com/tutorial/ajax-file-upload-tutorial.html

Well I'm not saving the file in the app, I just want to attach it to a mail

but before that, it needs to be uploaded to the server, which you cannot do by using a normal AJAX request

Oh, so there's no way to attach a file to mail without saving it in storage then?

there is, (you can keep the file in memory instead of write it to the storage) but you still need to send the file to the server (upload), which cannot be done (easily) via ajax.

Uploading does not necessarily mean that the server has to write the file to disk, it only means that a client sends a file to a server, and that is where you are stuck now because of the ajax request.

Try adding a nullable rule to your file rules.

You should also check whether the request has a file to process, before just blindly trying to process it.

if ($request->has('file')) {
    // do the processing for $request->file
}

Ok so I added nullable to my FormRequest:

public function rules()
    {
        return [
            
            'body' => 'required|string|min:5',
            
            'file' => 'nullable|mimes:doc,pdf,docx,zip,odt,jpeg,bmp,png,jpg,svg|max:2000'
        ];
    }

I also made quite a few changes to my controller method:

public function contactar_reportar_bug(BugReport $request)
    {
        
        $bug = new Bug();
        $bug->body = $request->body;
        $bug->save();
        
        
        if ($request->has('file')) {
            $uploadFile = $request->file('file');
            $mimetype = $uploadFile->getMimeType();
            $filename = str_random(6).'.'.$uploadFile->extension();
            $uploadFile->storeAs('uploads', $filename);
        }
        
        $sender_mail = config('globals.admin_mail');
        
        $destination_mail = config('globals.admin_mail');
        
        $client_phone = config('globals.client_phone');
        
        $body = $request->body;
        
        $restaurant = Globals::where('name' , 'Nombre del restaurante')->pluck('value');
        
        $subject = 'Nuevo reporte de bug en '.$restaurant;
        
        
        
        Mail::to($destination_mail)->send(new BugReportMail($body, $uploadFile, $filename, $mimetype, $subject, $restaurant, $client_phone, $sender_mail));
        
        return response()->json([
        
            'success' => 'Reporte de bug enviado',
            'bug' => $bug,

        ]);
    }

But I'm still getting the same mime related error message

You will still have a problem in your mail function, because you are sending $uploadFile to it, which won't exist unless the file exists since it only gets defined within the file check

if ($request->has('file')) {
    $uploadFile = $request->file('file');
    $mimetype = $uploadFile->getMimeType();
    $filename = str_random(6).'.'.$uploadFile->extension();
    $uploadFile->storeAs('uploads', $filename);
}

I'd add a $uploadFile = null; just before that file check, and then also need to check if it's null within your mailable view.

This is a hack and might not be the best solution, but it will probably work.

public function rules()
{
    $rules = [
        'body' => 'required|string|min:5',
    ];

    if (request()->has('file')) {
        $rules['file'] = 'nullable|mimes:doc,pdf,docx,zip,odt,jpeg,bmp,png,jpg,svg|max:2000';
    }

    return $rules;
}

Maybe someone has a better solution, but I'm just adding the mimecheck if there is a file present in the request.

Will report back once I get home, thx

Welp, I'm still getting the same mime validation error, I changed my form request:

 public function rules()
    {
        $rules = [
            'body' => 'required|string|min:5',
        ];

        if (request()->has('file')) {
            $rules['file'] = 'nullable|mimes:doc,pdf,docx,zip,odt,jpeg,bmp,png,jpg,svg|max:2000';
        }

    return $rules;
    }

And added the file check to my method controller:

public function contactar_reportar_bug(BugReport $request)
    {
        
        $bug = new Bug();
        $bug->body = $request->body;
        $bug->save();
        
        $uploadFile = null; 
        
        if ($request->has('file')) {
            $uploadFile = $request->file('file');
            $mimetype = $uploadFile->getMimeType();
            $filename = str_random(6).'.'.$uploadFile->extension();
            $uploadFile->storeAs('uploads', $filename);
        }
        
        $sender_mail = config('globals.admin_mail');
        
        $destination_mail = config('globals.admin_mail');
        
        $client_phone = config('globals.client_phone');
        
        $body = $request->body;
        
        $restaurant = Globals::where('name' , 'Nombre del restaurante')->pluck('value');
        
        $subject = 'Nuevo reporte de bug en '.$restaurant;
        
        
        
        Mail::to($destination_mail)->send(new BugReportMail($body, $uploadFile, $filename, $mimetype, $subject, $restaurant, $client_phone, $sender_mail));
        
        return response()->json([
        
            'success' => 'Reporte de bug enviado',
            'bug' => $bug,

        ]);
    }

And as recommended by Cronix I edited my mailable class to check if a file exists:

public function build()
    {
        
        if( is_null($this->uploadFile))
        {
            
            return $this->markdown('emails.bug_reports')
            ->from($this->sender_mail, 'BugReportGab')
            ->subject($this->subject);
            
        }
        
        
        return $this->markdown('emails.bug_reports')
        ->from($this->sender_mail, 'BugReportGab')
        ->subject($this->subject)
        ->attach($this->uploadFile, [
            'as' => $this->filename,
            'mime' => $this->mimetype,
        ]);
    }

Then stop sending the file as a text field via ajax:

As i said before, you cannot upload a file via ajax that way, you can do it in a plain XMLHttpRequest but not via the jquery $.ajax function

So either remove this line:

        formData.append('file', $('#bug_file').prop('files')[0]);

Or change your javascript upload to be able to actually upload that file. Check here for an example of how you can do a file upload via $.ajax()

https://abandon.ie/notebook/simple-file-uploads-using-jquery-ajax