Small Bug

I may have found a small bug in your app. At 8:35 Jeffrey says:

I just saw a mistake I made. Right now we're checking to see if a string has a method string. We actually need to new up the controller. So let's new up the controller here, then check to see if it has the action, then finally call the action."

But the bug fix may have a bug! Look at Line 46

throw new Exception ("{$controller} does not respond to the ${action} action.");

Let say that we mistakenly change our PagesController's

public function contact() to public function contactXXX()

We would expect the Exception to say:

Fatal error: Uncaught Exception: PagesController does not respond to the contact action.

But it doesn't. Instead, it says:

Recoverable fatal error: Object of class PagesController could not be converted to string

This is because {$controller} in the interpolated string is referencing the instantiated object, not the string passed in.

To fix it this we can change the name of the instantiated controller object to be unambiguous:

protected function callAction($controller, $action)
{
    $controllerObject = new $controller;

    if (! method_exists($controllerObject, $action)) {
        throw new Exception (
            "{$controller} does not respond to the ${action} action."
        );
    }

    return $controllerObject->$action();
}

Then the $controller in the interpolated string in the throw new Exception statement actually will be the string parameter.

Note: tested on Macs running 10.13 and 10.14 using default dev installation of PHP 7.1.23

Refactoring to Controller Classes

Updated Series Available