Great tutorial overall, but so many bad practices :(

The tests are so fragile and will break for reasons unrelated to functionality because they're frequently tied to overly vague or overly specific things.

For example, checking you're on the homepage by looking for the word "Posts". This could change easily because it's not an element specifically related to the homepage -- it could be renamed or moved. (It would have been better to create a project that was closer to reality to work from -- in reality there would be a better indicator that you were on the homepage.)

Another example is when you use the button[type=submit] selector. Not only is "type=submit" redundant on a button element, and so likely to be removed by another developer at some point, but if another form is added to the page your test will break.

By not showing consideration for these things in pursuit of quickly showing off the features of Dusk you're inadvertently encouraging bad habits. It's so important for developers to ALWAYS be thinking of these things: How tightly coupled is my code? What is likely to change in the future? Will my code break if those things change? ALWAYS -- until it becomes part of your normal process.

Beginners and juniors follow tutorials like this and don't understand that you're deliberately missing these important mental steps in order to demonstrate the features of the package quickly. And then a senior tries to instil good habits to help them understand this, they think "Well, that skilled teacher I watched didn't bother thinking about those things!".

I wish teachers would follow best practices as part of their tutorials, even if they don't explain exactly what they're doing. Or at least caveat this behaviour with, "obviously you would want your tests to be more robust in the real world, I'm only doing it this way for demo purposes".

Thanks Andre!

Post Tests