naykel

Simple as adding return

return $this->redirectTo()

Hello, I have created a reusable toolbar setting the buttons with different values so I can perform redirects using a switch statement base on the values. For the most part this works exactly exactly as I want..

public function update(Course $course)   {

    // other validate and save actions goes here

    switch (request('action')) {

        case 'save_stay':
            return back()->with('flash', 'Course saved!');
            break;

        case 'save_close':
            return redirect('admin/courses')->with('flash', 'Course saved!');
            break;

        case 'save_new':
            return redirect(route('admin.courses.create'))->with('flash', 'Course saved!');
            break;

        case 'back':
            return redirect('admin/courses');
            break;
    }
}

This toolbar works for both storeand update methods so I would like to make a resuable function, however the redirects no longer work. What am I missing here?

public function store(Course $course) {

    // other validate and save actions goes here

    $this->redirectTo(request('action'));
}

public function update(Course $course) {

    // other validate and save actions goes here

    $this->redirectTo(request('action'));
}

public function redirectTo($action)  {
    switch ($action) {

        case 'save_stay':
            return back()->with('flash', 'Course saved!');
            break;

        case 'save_close':
            return redirect('admin/courses')->with('flash', 'Course saved!');
            break;

        case 'save_new':
            return redirect(route('admin.courses.create'))->with('flash', 'Course saved!');
            break;

        case 'back':
            return redirect('admin/courses');
            break;
    }
}

Thanks for the input, I see that there are many ways and all of your answers gave me a little more clarity and if nothing more gave me some better questions to google. Time to stop procrastinating and get things done!

I am trying to adopt the SOLID design principles while keeping with the 'Single Responsibility Principle' I have moved my form validation from my controller to it own 'Form Request'. While this seemed pretty straight it some cases it raised more questions, specifically when it comes to data manipulation.

For example, I have recently discovered it is considered good practice to store money values in cents. Therefore at some point there needs to be a calculation to manipulate the value from dollars to cents or vice versa.

Should this be done in the 'UpdateProductRequest' or the 'ProductController' or somewhere else again?

// ProductController
public function update(ValidateProduct $request, Product $product) {

    $validatedData = $request->all();

    $product->update($validatedData);
    
}


// UpdateProductRequest
public function rules()
{
    $validatedData = [
        'name' => 'required|min:3',
        'price' => 'sometimes|numeric',
    ];
    
    $validatedData['price'] = $validatedData['price'] * 100;
    
    return $validatedData;
}